Implements MSC3773 (Thread Notifications) #7424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eserver capatibilities
…s_and_receipts' into feature/eric/msc3773 # Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt
ericdecanini
changed the base branch from
feature/nfe/threads_notifications_and_receipts
to
develop
bmarty
reviewed
Oct 21, 2022
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks. 2 first remarks on the form.
| val threadList = it.invoke() | ||
| val isUserMentioned = threadList?.firstOrNull { threadRootEvent -> | ||
| threadRootEvent.root.threadDetails?.threadNotificationState == ThreadNotificationState.NEW_HIGHLIGHTED_MESSAGE | ||
| }?.let { true } ?: false |
Member
There was a problem hiding this comment.
Suggested change
| }?.let { true } ?: false | |
| } != null |
is maybe simpler
| ) | ||
| ) | ||
| } | ||
| val threadNotificationsSupported = session.homeServerCapabilitiesService().getHomeServerCapabilities().canUseThreadReadReceiptsAndNotifications |
Member
There was a problem hiding this comment.
Keeping if (room == null) return would simplify the rest of the code.
# Conflicts: # matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Implements MSC3773
Motivation and context
Closes #6997
Thread notifications now come with sync response. This must be opted into and should also be able to fall back to previous homeserver versions that don't support the new unread thread notifications api.
Screenshots / GIFs
N/A
Tests
Tested devices
Checklist